Fix 'unknown language', coreml loading and bump whisper #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the GGML problem where the Whisper library has incorrect linking info, causing it to struggle to find the libraries. Manually loading them works as a temporary fix, but we should really clean up the dylib links using a tool like RepairWheel for a proper solution. See the next commit.
|
I add the dylibs to the libs folder recently to fix an issue but forgot to load them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are pretty safe. I’ve tested Whisper 1.7.1, and it’s working well with all tests passing; I’m using it right now. The CoreML was functioning, but it broke when I deleted the build directory because it was being pulled from there. I fixed it the same way we handle loading GGML. I think I have a better solution in mind, but since it’s a substantial change, I’ve decided to put it in a separate pull request.