Various design fixes and libadwaita usage improvements #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it automatically loads stylesheet and would allow nicer things later on
that is their default values
Adwaita does that automatically for us
Instead of the messy over-complicated GtkPaned and use AdwStatusPage as well while at it
As that is the proper way to do it, instead of hacking a lot of things around. In the next commit i will add more features wrapping the models to make it worth it
Useless...
Avoids a warning when using the set_sort_func
|
please don't review or merge yet, i got plenty more cleanup commits locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Far from ready, could use some proper review/testing but it is slightly better than current status quo
the whole sidebar needs proper design so i will wait for Allan or someone else to chime in before fixing it