Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference resolved helm toolchain for the host #75

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

kormide
Copy link
Contributor

@kormide kormide commented Apr 25, 2024

This allows you to run the resolved helm toolchain as a local tool, e.g.

bazel run @helm//:helm ...

This is a technique we use in aspect_bazel_lib for several tools like jq: https://github.com/aspect-build/bazel-lib/blob/main/lib/private/jq_toolchain.bzl#L202

@kormide kormide force-pushed the helm-host-repo branch 2 times, most recently from 549123a to 364fe51 Compare April 25, 2024 01:43
Copy link
Owner

@abrisco abrisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like the only outstanding issues are from buildifier, if you could fix those I'm happy to merge!

/home/runner/work/rules_helm/rules_helm/helm/extensions.bzl # reformat
/home/runner/work/rules_helm/rules_helm/helm/repositories.bzl # reformat

@kormide
Copy link
Contributor Author

kormide commented Apr 25, 2024

Thanks! Updated.

@kormide kormide requested a review from abrisco April 25, 2024 17:11
@abrisco abrisco merged commit eb91f2d into abrisco:main Apr 25, 2024
11 checks passed
@abrisco
Copy link
Owner

abrisco commented May 12, 2024

@kormide just a heads up: bazelbuild/bazel#22303 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants