Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#210: Project data extendable feature #667

Closed
wants to merge 1 commit into from
Closed

#210: Project data extendable feature #667

wants to merge 1 commit into from

Conversation

AkshayMuthal
Copy link

Added feature to:

  1. Make project data block extendable.
  2. Providing an option to open project data in a modal window by clicking "Project Data" button.

image
image

@AkshayMuthal
Project data extendable feature
9822e21 
Signed-off-by: Akshay Muthal <[email protected]>
@AkshayMuthal AkshayMuthal changed the title Issue #210: Project data extendable feature #210: Project data extendable feature Apr 8, 2023
@AkshayMuthal AkshayMuthal mentioned this pull request Apr 10, 2023
Closed
@tdruez
Copy link
Contributor

tdruez commented Apr 10, 2023 •
edited
Loading

@AkshayMuthal a better UI, instead of a modal, would be to implement on the project data section something similar to the Show/Hide at https://bulma.io/documentation/elements/box/ including the ability to copy the content.

@AkshayMuthal
Copy link
Author

AkshayMuthal commented Apr 12, 2023 •
edited
Loading

@tdruez

  1. Added a button to Show/Hide project data.
  2. Copy button in the top right corner which copies the project data code.
    Is this UI fine?
    Will update PR after this change.
    image

@tdruez
Copy link
Contributor

tdruez commented Apr 12, 2023

@AkshayMuthal the buttons should be integrated inside the data box, similar to https://bulma.io/documentation/elements/box/

@tdruez
Copy link
Contributor

tdruez commented Jun 9, 2023

Implemented in #777

@tdruez tdruez closed this Jun 9, 2023
@mjherzog mjherzog mentioned this pull request Jul 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AkshayMuthal @tdruez