Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency issues #586

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Fix dependency issues #586

merged 3 commits into from
Jan 16, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

scancode-toolkit 31.2.3 and 31.2.4 has bugfixes for a number of dependency issues which was breaking toolkit and others. These dependency fixes were:

  • spdx-tools has been pinned to 0.7.0a3 to guard against upcoming breaking changes.

  • the installation issues with packaging version 22.0 is fixed by replacing it with packvers

  • license index unpickling issue because of the new attrs release 22.2.0 is fixed by vendoring attrs for use in the license index code.

Signed-off-by: Ayan Sinha Mahapatra [email protected]

scancode-toolkit 31.2.3 and 31.2.4 has bugfixes for a number of
dependency issues which was breaking toolkit and others. These
dependency fixes were:

* spdx-tools has been pinned to `0.7.0a3` to guard against
  upcoming breaking changes.

* the installation issues with `packaging` version 22.0 is
  fixed by replacing it with `packvers`

* license index unpickling issue because of the new `attrs`
  release `22.2.0` is fixed by vendoring attrs for use in
  the license index code.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

AyanSinhaMahapatra commented Jan 13, 2023

We still need to merge an release aboutcode-org/python-inspector#109 for this though. I'm getting this error on docker compose up, which is basically aboutcode-org/python-inspector#108:
https://github.com/nexB/scancode.io/actions/runs/3913831012/jobs/6690190714#step:5:45

@swastkk
Copy link
Contributor

swastkk commented Jan 13, 2023

Can I work on this @AyanSinhaMahapatra ?

@AyanSinhaMahapatra
Copy link
Member Author

@swastkk you already did! Thanks ++

Here we just need to get python-inspector released and then scancode.io released (hopefully if nothing else breaks), for which we need to tag and push, and only maintainers have access.

@swastkk
Copy link
Contributor

swastkk commented Jan 13, 2023

@swastkk you already did! Thanks ++

Here we just need to get python-inspector released and then scancode.io released (hopefully if nothing else breaks), for which we need to tag and push, and only maintainers have access.

Okay ✨

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

@pombredanne this is all green!

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pombredanne pombredanne merged commit 0b4053e into main Jan 16, 2023
@pombredanne pombredanne deleted the fix-dep-issues branch January 16, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants