Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search functionality is not working for archive project #541

Open
shusriva opened this issue Oct 7, 2022 · 11 comments
Open

Search functionality is not working for archive project #541

shusriva opened this issue Oct 7, 2022 · 11 comments

Comments

@shusriva
Copy link

shusriva commented Oct 7, 2022

Hi Team,

I have deployed scancode on kubernetes cluster. After scanning docker images, we archive the project to save the disk space.
Now we are not able to search the project. In short, search functionality is not working for the archive project.

image

image

@pombredanne
Copy link
Member

@shusriva did you try to click on the "archived" link first?
Also you can as a work around also tweak the URL this way:
https:///project/?search=foo&is_archived=true

@pombredanne
Copy link
Member

I have deployed scancode on kubernetes cluster.

very nice! did you use @xerrni helm charts at https://github.com/xerrni/scancode-kube ?

Also you scanned 189 images. That's mighty cool. Any feedback you can share?
Any quirks to report or things to improve?
Anything you can share would be awesome! we are hungry for reports and news :)

@tdruez
Copy link
Contributor

tdruez commented Oct 7, 2022

I'll provide a fix to keep the filters state when submitting a search (searching currently reset all filters).

@shusriva
Copy link
Author

shusriva commented Oct 7, 2022

@pombredanne Thank you, yes I have used the same helm chart from @xerrni .
Feedback:

  1. Chart need some more improvement, I was unable to configure my existing postgres and redis because of dynamic cred. env variables needs to be configured in the chart to use existing psotgres and redis

  2. storage class is not defined explicitly in values.yaml file, hence we are forced to use local path for scancode. please provide options in values.yaml to explictly mention the storage class

  3. scancode pods are not coming up if any other storage class is used (e.g ebs-ssd from aws)

  4. I am successfully able to scanned 189 images but there are certain images whose pipelines got failed. I am not sure how to fix that.
    image
    image
    image

  5. If the pipelines fails what does it implies, Its the constraint of the tool or image is not fit to be utilized in production. what shall we convey to the management

  6. https:///project/?search=foo&is_archived=true this workaround worked for me. please provide the fix in the helm chart as well

tdruez added a commit that referenced this issue Oct 7, 2022
tdruez added a commit that referenced this issue Oct 7, 2022
@tdruez
Copy link
Contributor

tdruez commented Oct 7, 2022

@shusriva the fix for the search is now available in the main branch.
All active filters state is now kept when running a search.
You can now click on "Archived" and then run the search, or run the search then click "Archived".

Thanks for reporting the various issues, we'll look into those and provide you feedback.

@shusriva
Copy link
Author

shusriva commented Oct 8, 2022

@tdruez Thanks for the fix, Do i need to update anything in the helm chart ? or shall i deploy the new version of helm chart to get this fix

@tdruez
Copy link
Contributor

tdruez commented Oct 10, 2022

@shusriva I've moved 1. 2. 3. to #461 (comment)

  1. I am successfully able to scanned 189 images but there are certain images whose pipelines got failed. I am not sure how to fix that.

I've try those failing inputs with the latest version of ScanCode.io and everything seems to work fine. My guess is that you a not running the latest ScanCode.io (that includes the latest ScanCode-toolkit) that contains the fix for the failing RPM detection.

  1. If the pipelines fails what does it implies, Its the constraint of the tool or image is not fit to be utilized in production. what shall we convey to the management

A failing pipeline run is usually due to a bug in the code, or to a provided input that is not expected by the pipeline type.
For example load_inventory expect a json as input and will fail if you provide anything else.

Do i need to update anything in the helm chart ? or shall i deploy the new version of helm chart to get this fix

I have not used this Helm chart deployment yet so we'll need @xerrni input on this. Please let us know once you figure this out so we can add a new "Update" section in the Helm chart documentation.

@shusriva
Copy link
Author

shusriva commented Oct 10, 2022

@tdruez Thank you for your response.
I am currently using the helm chart for deploying the scancode in my kubernetes cluster. I am not sure weather the latest scancode-toolkit is included in the helm chart or not. I am also not sure whether the archive search issue fix is incorporated in the helm chart. There are around 200 images which is already scan. it took around 3 days to complete the scanning. If I update the chart version, i guess all the scan results will be deleted. @xerrni input is required

@tdruez
Copy link
Contributor

tdruez commented Oct 10, 2022

i guess all the scan results will be deleted.

Not if you keep the same database. Not sure how it works in the Helm chart context though.

@shusriva
Copy link
Author

shusriva commented Dec 3, 2022

Hello @tdruez @pombredanne ,

Any update on the scancode Helm chart new release version.
In the current version, search functionality doesn't work in the archive section.
If there is any new release for scancode helm chart, Please provide the url.

@shusriva
Copy link
Author

Hi @tdruez @pombredanne ,
I have modified the scancode helm chart a bit to make it more aligned to industry standard. For e.g user can use the image stored in the private registry. user can also pass the custom storage class (eg ebs-ssd in case of aws) or local path provisioner in case of on premise.
can you please guide, where can i upload the modified helm chart and become the contributor for this tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants