Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance support for Package dependencies #228

Closed
tdruez opened this issue Jul 6, 2021 · 1 comment
Closed

Enhance support for Package dependencies #228

tdruez opened this issue Jul 6, 2021 · 1 comment
Assignees

Comments

@tdruez
Copy link
Contributor

tdruez commented Jul 6, 2021

Current implementation: https://github.com/nexB/scancode.io/blob/main/scanpipe/pipes/scancode.py#L400-L417

The dependencies are stored in the database along the discovered packages without any way to make a distinction from a regular package. This is problematic in many ways and causing more issues than benefits when dealing with the results.

2 steps improvements:

  1. Store the dependencies on a new field on the DiscoveredPackage model
  2. Implement a proper DependentPackage model related to the DiscoveredPackage

https://github.com/nexB/scancode-toolkit/blob/develop/src/packagedcode/models.py#L386

https://github.com/nexB/scancode-toolkit/blob/3f7da81d6b207ac2b1d384defb83a5f2c82216f4/src/packagedcode/models.py#L308

@tdruez
Copy link
Contributor Author

tdruez commented Jul 22, 2022

See #447 for implementation.

@tdruez tdruez closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant