Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return the Pipeline subclass/implementation from the module inspection #11

Closed
tdruez opened this issue Sep 17, 2020 · 0 comments
Closed

Always return the Pipeline subclass/implementation from the module inspection #11

tdruez opened this issue Sep 17, 2020 · 0 comments
Assignees
@tdruez
Labels
bug Something isn't working

Comments

@tdruez
Copy link
Contributor

tdruez commented Sep 17, 2020

The current get_pipeline_class implementation may return the Pipeline base class in place of the actual subclass we are looking for. This appears to be random since it is based on the order of the list returned by inspect.getmembers.
@tdruez tdruez added the bug Something isn't working label Sep 17, 2020
@tdruez tdruez self-assigned this Sep 17, 2020
tdruez added a commit that referenced this issue Sep 17, 2020
@tdruez
Fix the get_pipeline_class to only return subclass of Pipeline #11
e0224d2 
Signed-off-by: Thomas Druez <[email protected]>
pombredanne added a commit that referenced this issue Sep 17, 2020
@pombredanne
Merge pull request #12 from nexB/11-get-pipeline-class
64fca82 
Fix the get_pipeline_class to only return subclass of Pipeline #11
@tdruez tdruez closed this as completed Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdruez tdruez

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tdruez