Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go inspector #3972

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Update go inspector #3972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38cbabb
Update go-inspector to v0.5.0
JonoYang Nov 5, 2024
f450020
Continue when an exception has been encountered during package recogn…
JonoYang Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements-linux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
packagedcode-msitools==0.101.210706
regipy==3.1.0
rpm-inspector-rpm==4.16.1.3.210404
go-inspector==0.3.1
go-inspector==0.5.0
2 changes: 1 addition & 1 deletion setup-mini.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ packages =
rpm_inspector_rpm >= 4.16.1.3; platform_system == 'Linux'
regipy >= 3.1.0; platform_system == 'Linux'
packagedcode_msitools >= 0.101.210706; platform_system == 'Linux'
go-inspector >= 0.3.1; platform_system == 'Linux'
go-inspector >= 0.5.0; platform_system == 'Linux'


[options.entry_points]
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ packages =
rpm_inspector_rpm >= 4.16.1.3; platform_system == 'Linux'
regipy >= 3.1.0; platform_system == 'Linux'
packagedcode_msitools >= 0.101.210706; platform_system == 'Linux'
go-inspector >= 0.3.1; platform_system == 'Linux'
go-inspector >= 0.5.0; platform_system == 'Linux'


[options.entry_points]
Expand Down
8 changes: 8 additions & 0 deletions src/packagedcode/recognize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,3 +113,11 @@ def _parse(

if TRACE:
raise

except Exception as e:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AyanSinhaMahapatra @pombredanne I'm not sure if this is the best solution for #3971, I'd like to know if you guys have any better ideas.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine in the short term, see #3971 (comment)

# We should continue when an Exception has occured when trying to
# recognize a package
if TRACE:
logger_debug(f'_parse: Exception: {str(e)}')

continue
Loading