License detection improvements and review #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Clark <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This is a 100% relevant reference Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This helps to get a more accurate and correct detection Signed-off-by: Philippe Ombredanne <[email protected]>
Add new rules to improve detection accuracy in phpwiki. Reference: #3256 Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
These are mostly seen in some Debian copyright files Signed-off-by: Philippe Ombredanne <[email protected]>
These are weird but seen frequently enough Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Also treat some capitalized words as no proper nouns Signed-off-by: Philippe Ombredanne <[email protected]>
Dot not treat solo period as NN Allow trailing "authors" as part of copyright Handle more case of truncated copyrights Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
…les' into license-detection-improvements-and-review
* Remove duplicated tests * Do not strip leading @ sign in words * Streamline some lexer regex (they were incorrectly handling dots) * Add new copyright statement variants Signed-off-by: Philippe Ombredanne <[email protected]>
* Adds a new --todo post scan option to review potential ambiguous license/package detections * Adds a `todo` top level attribute with these review items which is a `ToDo` list for the reviewer Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
These solve the following license detection bugs: * #3361 * #3360 * #3358 * #3355 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
…-and-review' into license-detection-improvements-and-review
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
AyanSinhaMahapatra
force-pushed
the
license-detection-improvements-and-review
branch
from
b36bb73 to
86151a8
Compare
Reference: #3409 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
license-detection-improvements-and-review
branch
from
86151a8 to
886bc39
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Fixes unknown-spdx detections for nuget nuspecs file license detection where a dangling </licenseurl> markup would result in the SPDX license detection not working. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
For the form of "Contributors to the project..." Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Somehow we need to re-raise an exception fo this to work correctly Signed-off-by: Philippe Ombredanne <[email protected]>
Do not fail to scan on timeout, instead keep on trucking and log errors. Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
license-detection-improvements-and-review
branch
from
b439760 to
ca92534
Compare
AyanSinhaMahapatra
force-pushed
the
license-detection-improvements-and-review
branch
2 times, most recently
from
05dd2ba to
6d439eb
Compare
Fixes a bug where top level license detections had license expressions and IDs which were not present anywhere in the scan. This was because we were dereferencing unknown license references after the unique license detection collections and so the modified identifiers and license expressions were not present in the top-level license detections. Fixes a bug where top level unique license detections were not properly collected from package license detections. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
license-detection-improvements-and-review
branch
from
6d439eb to
1bad407
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
license-detection-improvements-and-review
branch
from
48fe068 to
a87a4d5
Compare
pombredanne
commented
Jun 11, 2023
AyanSinhaMahapatra
restored the
license-detection-improvements-and-review
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds misc. license and copyright detection improvements and the
--todoscancode CLI option for review items summary.Tasks
Run tests locally to check for errors.