Improve packagecode and other release prep #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI and metainfo
check type annotations
* Also improve cleaning keywords Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Rather than trying to get things recompiled on ARM for now, we instead force relaunching the current shell script (scancode, configure, ...) under the x86_64 Intel architecture. This makes things work OK on macOS M1 and does not impact other OSes. Reference: #2938 Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This is borrowed from dephell_setuptools Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
We now include the original requirements as-is Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
improve-gradle
branch
from
7f1f52e to
6687b6f
Compare
|
Closing now, while fixing flaky tests |
The code that was computing depth was mistakenly counting iterations instead of computin the os.walk depth and this was the source of a seemingly randon issue in the CI. The reason why only the CI was failing is likely because Azure builds of Python have a slightly different set of defaults and the os.walk iteration order is not the same as a plain Ubuntu installation. Signed-off-by: Philippe Ombredanne <[email protected]>
YAML output is mostly strings. Some JSON output was numeric. Conversion to CSV was failing with --from-json using a JSON output converted by hand from a YAML output Signed-off-by: Philippe Ombredanne <[email protected]>
|
@JonoYang please have a look at this before I merge ... This is a bit of a mini mess of many unrelated things:
I could split this in multiple PRs instead. |
JonoYang
approved these changes
Jun 13, 2022
Reported-by: Jono Yang <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
|
@JonoYang Thanks! |
|
@pombredanne Thanks, merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
This is a potpourri towards the latest release.
Tasks
Run tests locally to check for errors.