Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure CI to not use ubuntu-16.04 images #2688

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Update Azure CI to not use ubuntu-16.04 images #2688

merged 1 commit into from
Sep 6, 2021

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Sep 3, 2021 •
edited
Loading

Fixes #2687

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the 2687-use-ubuntu-latest-on-azure branch from 09acb78 to 61d8b8d Compare September 6, 2021 09:51
pombredanne
pombredanne approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not use latest... And feel free to remove duplicate tests.
LGTM otherwise... please fix and merge!

@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the 2687-use-ubuntu-latest-on-azure branch from 61d8b8d to 3d551c2 Compare September 6, 2021 12:01
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit b5f4624 into develop Sep 6, 2021
@pombredanne pombredanne deleted the 2687-use-ubuntu-latest-on-azure branch September 21, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ubuntu-latest in azure
2 participants
@AyanSinhaMahapatra @pombredanne