#253 Ensure that opened files are closed

Signed-off-by: Philippe Ombredanne <[email protected]>
aboutcode-org · Dec 6, 2016 · a58ca53 · a58ca53
1 parent 0d4905b
commit a58ca53
Showing 1 changed file with 14 additions and 18 deletions.
diff --git a/src/packagedcode/pypi.py b/src/packagedcode/pypi.py
@@ -64,24 +64,20 @@ def parse_pkg_info(location):
     parse a 'PKG-INFO' file at 'location' and return a PythonPackage object.
     """
     infos = {}
-    with open(location, 'rb') as txt_file:
-        lines = []
-        for line in txt_file:
-            lines.append(line)
-        lines = ''.join(lines)
-        for attribute in PKG_INFO_ATTRIBUTES:
-            infos[attribute] = re.findall('^'+attribute+'[\s:]*.*', lines, flags=re.MULTILINE)[0]
-            infos[attribute] = re.sub('^'+attribute+'[\s:]*', '', infos[attribute], flags=re.MULTILINE)
-            if infos[attribute] == 'UNKNOWN':
-                infos[attribute] = None
-        package = PythonPackage(
-            name=infos.get('Name'),
-            version=infos.get('Version'),
-            summary=infos.get('Summary'),
-            homepage_url=infos.get('Home-page'),
-            asserted_licenses=[AssertedLicense(license=infos.get('License'))],
-            authors=[infos.get('Author')],
-        )
+    file_text = open(location, 'rb').read()
+    for attribute in PKG_INFO_ATTRIBUTES:
+        infos[attribute] = re.findall('^'+attribute+'[\s:]*.*', file_text, flags=re.MULTILINE)[0]
+        infos[attribute] = re.sub('^'+attribute+'[\s:]*', '', infos[attribute], flags=re.MULTILINE)
+        if infos[attribute] == 'UNKNOWN':
+            infos[attribute] = None
+    package = PythonPackage(
+        name=infos.get('Name'),
+        version=infos.get('Version'),
+        summary=infos.get('Summary'),
+        homepage_url=infos.get('Home-page'),
+        asserted_licenses=[AssertedLicense(license=infos.get('License'))],
+        authors=[infos.get('Author')],
+    )
     return package