Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comments in netrc file #107 #122

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Support comments in netrc file #107 #122

merged 3 commits into from
Feb 23, 2023

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Feb 6, 2023

Reference: #107
Signed-off-by: Tushar Goel [email protected]

@TG1999 TG1999 requested a review from pombredanne February 6, 2023 17:49
pombredanne
pombredanne requested changes Feb 10, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... see some comments to consider

src/python_inspector/utils.py Outdated Show resolved Hide resolved
src/python_inspector/utils.py Outdated Show resolved Hide resolved
src/python_inspector/utils.py Outdated Show resolved Hide resolved
@pombredanne
Copy link
Member

Also, I wonder if we really need tinynetrc and cannot instead directly use the netrc standard library module?

@TG1999
Copy link
Contributor Author

TG1999 commented Feb 10, 2023

Also, I wonder if we really need tinynetrc and cannot instead directly use the netrc standard library module?

Makes sense trying the standard netrc module

@TG1999 TG1999 force-pushed the ignore_comments_from_netrc branch from 4f5c636 to 9f265fb Compare February 14, 2023 14:54
@TG1999 TG1999 requested a review from pombredanne February 14, 2023 15:01
pombredanne
pombredanne approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! you just need to remove the dep on tinynetrc

@TG1999 TG1999 linked an issue Feb 17, 2023 that may be closed by this pull request
Python Inspector does not support comments in .netrc files #107
Open
@TG1999 TG1999 force-pushed the ignore_comments_from_netrc branch from 9b9013a to 8c84cb9 Compare February 17, 2023 14:34
@TG1999
Add support for comments in netrc file
f81111c 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Address review comments
f3bd5f0 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Add CHANGELOG
9bdb540 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 force-pushed the ignore_comments_from_netrc branch from 8c84cb9 to 9bdb540 Compare February 23, 2023 09:56
@TG1999 TG1999 merged commit ed46103 into main Feb 23, 2023
@TG1999 TG1999 deleted the ignore_comments_from_netrc branch February 23, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python Inspector does not support comments in .netrc files
2 participants
@TG1999 @pombredanne