Adjust as_unicode for breaking bs4 4.13 changes
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: aboutcode-org#79 See: https://git.launchpad.net/beautifulsoup/tree/CHANGELOG#n431 Signed-off-by: Jürgen Löhel <[email protected]>
Use latest bs4 version Signed-off-by: Jürgen Löhel <[email protected]>
AyanSinhaMahapatra
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Thanks++ @jloehel for the fix.
This is probably also causing issues elsewhere and in scancode.io which would be fixed by this like:
- a bytes-like object is required, not 'str - VM unpacking scancode.io#1578
- Can not extract archive file in pipline by extract_archives: worker-1 | INFO [error] normalize() argument 2 must be str, not bytes scancode.io#1577
- copyright scan error scancode-toolkit#4129
This seems like the same error messages reported in https://dev.azure.com/nexB/commoncode/_build/results?buildId=15418&view=logs&j=51e48696-633a-5fd5-beca-0cdec502e01c&t=1127802e-76e7-5642-21b8-a4a09f29d7bf
Note that the CI failures are just deprecated images and should be fixed by #81, as the combined commit passes CI tests https://dev.azure.com/nexB/commoncode/_build/results?buildId=15421&view=results
AyanSinhaMahapatra
merged commit 8bf864f
into
aboutcode-org:main
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #79
See: https://git.launchpad.net/beautifulsoup/tree/CHANGELOG#n431