Support for memory in decimal GiB #1205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abiosoft
reviewed
Dec 4, 2024
| @@ -60,7 +60,7 @@ func newConf(ctx context.Context, conf config.Config) (l limaconfig.Config, err | |||
| l.CPUs = &conf.CPU | |||
| } | |||
| if conf.Memory > 0 { | |||
| l.Memory = fmt.Sprintf("%dGiB", conf.Memory) | |||
| l.Memory = fmt.Sprintf("%dMiB", uint32(conf.Memory*1024)) //memorySize is a multiple of 1 megabyte | |||
There was a problem hiding this comment.
The comment is not needed.
Suggested change
| l.Memory = fmt.Sprintf("%dMiB", uint32(conf.Memory*1024)) //memorySize is a multiple of 1 megabyte | |
| l.Memory = fmt.Sprintf("%dMiB", uint32(conf.Memory*1024)) |
abiosoft
reviewed
Dec 4, 2024
abiosoft
reviewed
Dec 4, 2024
|
@qiao-summer any reason why you closed the pull request? |
|
@abiosoft I resubmitted with another pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colima start --cpu 1 --memory 0.8 --disk 10