Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always installs latest version of code server #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Always installs latest version of code server #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion colabcode/code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ def __init__(
def _install_code():
subprocess.run(["wget", "https://code-server.dev/install.sh"], stdout=subprocess.PIPE)
subprocess.run(
["sh", "install.sh", "--version", f"{CODESERVER_VERSION}"],
# ["sh", "install.sh", "--version", f"{CODESERVER_VERSION}"],
Copy link

@sb0210 sb0210 Jul 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Code can be improved.
output of subprocess.run command is not taken care of.
Comments can be removed.

def _install_code():
    result = subprocess.run(["wget", "https://code-server.dev/install.sh"], stdout=subprocess.PIPE)
    if result.returncode != 0:
        raise RuntimeError("Failed to download installation script")
        
    result = subprocess.run(["sh", "install.sh"], stdout=subprocess.PIPE)
    if result.returncode != 0:
        raise RuntimeError("Failed to run installation script")

["sh", "install.sh"],
stdout=subprocess.PIPE,
)

Expand Down