feat(core): add aws external account subject token #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i10416
commented
Nov 27, 2024
i10416
commented
Nov 27, 2024
i10416
commented
Nov 27, 2024
i10416
commented
Nov 27, 2024
default credentials chain includes all the common credential sources.
i10416
changed the title
i10416
commented
Nov 27, 2024
i10416
changed the title
abdolence
reviewed
Nov 30, 2024
abdolence
reviewed
Nov 30, 2024
|
This seems a really good work, thanks for contribution 🏆 Currently I have limited capabilities to test it with the real AWS, so I'll do it a bit testing after merging it. Thanks! |
i10416
force-pushed
the
feat/aws-external-account-auth
branch
from
f419c6d to
fa3979a
Compare
abdolence
approved these changes
Dec 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersede #120
close #29