Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild not possible #38

Closed
Apollon77 opened this issue Jan 11, 2022 · 9 comments · Fixed by #39
Closed

Rebuild not possible #38

Apollon77 opened this issue Jan 11, 2022 · 9 comments · Fixed by #39

Comments

@Apollon77
Copy link

I did some nodejs upgrade tests and had bigger issues getting bluetooth-hci-socket rebuilded because by default it simply told

[@abandonware/bluetooth-hci-socket] Success: "/opt/iobroker/node_modules/@abandonware/bluetooth-hci-socket/lib/binding/bluetooth_hci_socket.node" already installed
Pass --update-binary to reinstall or --build-from-source to recompile

I tried many things and did a bigger research. There is no way to add more parameters to the "nom rebuild" command, so in the end "npm i" would be the only option (with other side effects).

In fact I ended up in adding "--update-binary" to the "install script" and with this a rebuild was successful too ...

Apollon77 added a commit to Apollon77/node-bluetooth-hci-socket that referenced this issue Jan 11, 2022
@rzr rzr closed this as completed in #39 Jan 11, 2022
rzr pushed a commit that referenced this issue Jan 11, 2022
@Apollon77
Copy link
Author

@rzr would you also mind releasing it?

@rzr
Copy link

rzr commented Feb 11, 2022

you can do it too see history and submit a Release commit it will be released

@Apollon77
Copy link
Author

Yes you're right ... forgot that :-))

@Apollon77
Copy link
Author

@rzr If I would do it I would also upgrade the package-locj file because my dev system is already on npm 8 ... ok? Or would it be an option that you bump it?

@Apollon77
Copy link
Author

@rzr Any advice?

@rzr
Copy link

rzr commented Mar 19, 2022

npm install --global npm-check-updates

@Apollon77
Copy link
Author

@rzr it is not about finding updateable deps ... it i about the lock file and the version ... I can do the release PR but then it will have an updated lock file version (alnd also the abve script will not change that). is this acceptable?

@Apollon77
Copy link
Author

@rzr sorry to bother you again ... if it is ok that I update package lock to npm 8 then I can do the PR ... what's your opinion?

@rzr
Copy link

rzr commented Aug 29, 2022

yea sure try it , and look at history to create a PR to make a new release !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants