Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(permissions): Slash Permissions v2 #1372

Merged
merged 34 commits into from
Jan 9, 2024
Merged

feat(permissions): Slash Permissions v2 #1372

merged 34 commits into from
Jan 9, 2024

Conversation

coolcalcacol
Copy link
Contributor

@coolcalcacol coolcalcacol commented May 7, 2022 •
edited
Loading

Remove bulk editing of command permissions as the endpoint has been disabled,
add defaultMemberPermissions and dmPermission in place of defaultPermission,
add the applicationCommandPermissionsUpdate gateway event,
add the ApplicationCommandPermissionTypes channel type,
modify createGuildCommand to return without the new DMPermission field

@coolcalcacol
Remove bulk editing of command permissions as the endpoint has been d…
1f858dd 
…isabled, add defaultMemberPermissions and DMPermission in place of defaultPermission, add the applicationCommandPermissionsUpdate gateway event, the ApplicationCommandPermissionTypes channel type, modify createGuildCommand to return without the DMPermission field
@coolcalcacol
Add missing channel constant, and update formatting
dfac966
DonovanDMC
DonovanDMC suggested changes May 9, 2022
View reviewed changes
Copy link
Contributor

@DonovanDMC DonovanDMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keys should be camel cased

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
bsian03
bsian03 previously requested changes May 9, 2022
View reviewed changes
lib/gateway/Shard.js Outdated Show resolved Hide resolved
@coolcalcacol coolcalcacol requested a review from bsian03 May 10, 2022 14:16
DonovanDMC
DonovanDMC reviewed May 11, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@coolcalcacol @DonovanDMC
Update index.d.ts
c3e076d 
Co-authored-by: Donovan Daniels <[email protected]>
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request May 20, 2022
@DonovanDMC
Add http://abalabahaha/eris#1372
b70702f
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request May 20, 2022
@DonovanDMC
Add abalabahaha/eris#1372
41de494
DonovanDMC
DonovanDMC suggested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@DonovanDMC DonovanDMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsdoc hasn't been changed for Client#createGuildCommand

DonovanDMC
DonovanDMC suggested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@DonovanDMC DonovanDMC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bulkEditCommands/bulkEditGuildCommands does not properly replace the camel cased names with underscored names

DonovanDMC
DonovanDMC suggested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@DonovanDMC DonovanDMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editCommand / editGuildCommand also have not been modified

DonovanDMC
DonovanDMC reviewed May 21, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@coolcalcacol @DonovanDMC
Update index.d.ts
bb13698 
Co-authored-by: Donovan Daniels <[email protected]>
DonovanDMC
DonovanDMC suggested changes May 22, 2022
View reviewed changes
Copy link
Contributor

@DonovanDMC DonovanDMC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistent spacing (github isn't displaying it, but the newline after should also be removed)

lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
coolcalcacol and others added 2 commits May 23, 2022 00:27
@coolcalcacol @DonovanDMC
Update lib/Client.js
1fc0e5b 
Co-authored-by: Donovan Daniels <[email protected]>
@coolcalcacol @DonovanDMC
Update lib/Client.js
7e3fb6b 
Co-authored-by: Donovan Daniels <[email protected]>
DonovanDMC
DonovanDMC previously approved these changes May 23, 2022
View reviewed changes
@abalabahaha abalabahaha added this to the 0.18.x milestone Jun 29, 2022
bsian03
bsian03 requested changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audit log handling missing

lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/structures/Guild.js Outdated Show resolved Hide resolved
lib/structures/Guild.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@coolcalcacol coolcalcacol requested a review from bsian03 August 26, 2022 22:59
bsian03
bsian03 requested changes Aug 28, 2022
View reviewed changes
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/gateway/Shard.js Outdated Show resolved Hide resolved
bsian03
bsian03 requested changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to consider whether its worth having a separate ApplicationCommand class within Eris...

index.d.ts Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
lib/structures/Guild.js Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
@bsian03
Copy link
Collaborator

bsian03 commented Jan 6, 2024

Am redoing how application commands are handled so don't touch for now pls

@bsian03 bsian03 marked this pull request as draft January 6, 2024 21:44
@bsian03 bsian03 marked this pull request as ready for review January 7, 2024 15:21
@bsian03 bsian03 merged commit 3139ca9 into abalabahaha:dev Jan 9, 2024
@flav-code flav-code mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsian03 bsian03 bsian03 approved these changes

@DonovanDMC DonovanDMC DonovanDMC left review comments

Assignees
No one assigned
Labels
Discord
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@coolcalcacol @bsian03 @DonovanDMC @abalabahaha