Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace serde_derive with serde/derive #271

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Jan 24, 2025

Debian autopkgtests is very eager in trying to find all possible combinations, and tries to build the crate with cargo check --no-default-features --features serde, which currently doesn't work.

I'm patching this downstream, this change removes the need for that patch.

In theory this is a breaking change, in case somebody uses (for whatever reason):

irc = { version = "1", features = ["toml_config", "serde_derive"] }

this would not work anymore, you could work around this by having a feature named "serde_derive" that does nothing:

[features]
serde_derive = []

Copy link
Owner

@aatxe aatxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm okay with this, derive was never really intended on being optional separately from serde, but uhh... Hyrum's law, I suppose. So, hello to whoever this PR broke.

@aatxe aatxe merged commit 9aee9b8 into aatxe:develop Jan 25, 2025
3 checks passed
@kpcyrd kpcyrd deleted the serde-derive branch January 25, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants