Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies, set rust-version, and some more maintenance work #249

Merged
merged 2 commits into from
May 22, 2023

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented Apr 12, 2023

Reason for this change is that I noticed that the irc crate was the sole cause in my dependency graph for pulling in some old dependencies (parking_lot among others). Some dependencies had CVEs specified for versions which were inside of their minimal ranges. So I went ahead and ran a cargo upgrade --workspace here.

I used a tool which tried to build and detect the MSRV and updated rust-version. It also sorted the fields, as they are specified in the Cargo documentation. Hope this i OK, otherwise I'll pull it back.

Since features need to be additive, I've made it so that if both tls-rust and tls-native are activated, only tls-rust will be used. If you want this flipped, please tell me.

Finally I've added a Github workflow file, which performs most checks (including testing for MSRV). But I haven't ported any integration tests yet. So if you want to keep running them on Travis that is OK by me. You can see the run here.

@udoprog
Copy link
Contributor Author

udoprog commented Apr 12, 2023

Note the odd make_client_auth! macro, that one is necessary because the builder produced by calling with_custom_certificate_verifier vs. with_root_certificates have different return signatures, but still supports the same sequence of methods to configure it.

@aatxe
Copy link
Owner

aatxe commented May 22, 2023

Hm, sorry about the delay on this, but looks good. Appreciate the changes a lot, especially the GH Actions setup now that Travis is dead.

@aatxe aatxe merged commit 34aae72 into aatxe:develop May 22, 2023
@udoprog
Copy link
Contributor Author

udoprog commented May 22, 2023

Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants