better errors for missing certificates #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be used when the config contains a path but that file cannot be read.
made config::path pub(crate) to avoid code duplication but not pub so it is not part of the public API
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #212.
This introduces a new
ConfigErrorvariant for when the configuration contains a path but the respective file cannot be read (could be because the file is missing or because of permission problems). This new variant is then used if a specified certificate file (server or client certificate) cannot be read.To not duplicate code, I changed the visibility of
Config::pathtopub(crate)so it can be reused in the variants ofConnection::new_secured_transport.Not sure if or how to add tests for this.