closure syntax #12
Merged
closure syntax #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Atashian <[email protected]>
|
Looks good, but you've got to sign the CLA. |
ljrk0
added a commit
to ljrk0/irc
that referenced
this pull request
Jul 11, 2023
While this archive is indeed DER-formatted, in contrast to `cert_path`, a regular DER file created from some certificate/key PEM file won't work: ``` openssl x509 -outform der -in foo.pem -out foo.der ``` This will result in the following OpenSSL error through tls-native error: ``` error:068000A8:asn1 encoding routines:asn1_check_tlen:wrong tag:crypto/asn1/tasn_dec.c:1188: error:0688010A:asn1 encoding routines:asn1_d2i_ex_primitive:nested asn1 error:crypto/asn1/tasn_dec.c:752: error:0688010A:asn1 encoding routines:asn1_template_noexp_d2i:nested asn1 error:crypto/asn1/tasn_dec.c:685:Field=version, Type=PKCS12 ``` Instead, a PKCS aatxe#12 archive must be created like so: ``` openssl pkcs12 -export -out foo.p12 -inkey fookey.pem -in foocert.pem ``` If the PEM file contains both the private key and the certificate, the same file can be passed to `openssl` twice. Also compare the documentation for `from_pkcs12` to `from_der` in native-tls, as used in the `new_secured_transport` function: https://docs.rs/native-tls/0.2.11/native_tls/struct.Identity.html#method.from_pkcs12
aatxe
added a commit
that referenced
this pull request
Mar 18, 2024
CertFP: The file must be a PKCS #12 archive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.