Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow invalid certificates #230

Closed
PurpleMyst opened this issue Mar 4, 2021 · 6 comments
Closed

Allow invalid certificates #230

PurpleMyst opened this issue Mar 4, 2021 · 6 comments

Comments

@PurpleMyst
Copy link

As per the title, I'd enjoy it if there were an option to allow invalid certificates when connecting over TLS, as I believe this to be an use-case for connecting to a ZNC bouncer that has its own, self-signed, certificate, created by znc --makecert (or something of the like, I'm not sure that that's the right flag).

Currently, I get an error even if I convert the znc.pem into a znc.der and pass it in in the config.

@8573
Copy link

8573 commented Mar 4, 2021

I don't know that I'd call self-signed certificates "invalid". I think it would be appropriate to have an option to accept any certificate with a fingerprint in a given list of fingerprints, so one would provide the fingerprint of one's self-signed certificate, just as often is done with certificate authentication to IRC services.

@dabukalam
Copy link

I've run into this issue today as well, while trying to use https://github.com/nuxeh/url-bot-rs. Allowing self-signed certs somehow is def a good feature request.

@simnalamburt
Copy link
Contributor

Duplicate of #209

simnalamburt added a commit to simnalamburt/irc that referenced this issue Nov 14, 2021
This patch adds an option to dangerously ignore all ceritificate
verifications. This option must be used with extreme caution and should
only be used as a last resort.

Closes aatxe#209, aatxe#230

Co-authored-by: Hyeon Kim <[email protected]>
@simnalamburt
Copy link
Contributor

FYI, I've made a PR for this issue: #236

@ghost
Copy link

ghost commented Feb 19, 2022

Hey,
I second this and in the meantime I've just switched to tracking @simnalamburt's upstream:

irc = { git = "https://github.com/simnalamburt/irc.git", branch = "dangerously-accept-invalid-certs" }

https://github.com/clandestinenetworks/roobot/blob/master/src/main.rs#L15

and it seems to work just fine. thanks!

@quite
Copy link
Contributor

quite commented Feb 26, 2022

Closed by #236 it seems

@aatxe aatxe closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants