fix coloring in bash 🎉 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecma48 clears the data buffer when it emits an event. Bash sets multiple styles/colors in the same commend. So, the 2nd+ events emitted for these multi-style sequences had an empty data list, causing them to be ignored by vterm. IIRC, the original reason for skipping events with empty Raw data was for a bug that was fixed by rewriting the ecma48 parser.
aaronjanse
force-pushed
the
aj2020sep-fix-bash-colors
branch
from
2e00523 to
e1d650f
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecma48clears theRawdata buffer when it emits an event. Bash sets multiple styles/colors in the same commend. So, the 2nd+ events emitted for these multi-style sequences had an emptyRawdata list, causing them to be ignored by vterm.I think the original reason for skipping events with empty Raw data was for a bug that was fixed by rewriting the ecma48
parser.