Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flake.nix #114

Merged
merged 8 commits into from
Mar 8, 2021
Merged

add flake.nix #114

merged 8 commits into from
Mar 8, 2021

Conversation

aaronjanse
Copy link
Owner

Nix is a declarative package manager used by myself and many of our users. This PR lets Nix users try 3mux by simply running:

nix run github:aaronjanse/3mux

This is made possible by replacing shell.nix with flake.nix, which supports some cool features in Nix 2.4 like the command above.

Sadly, to a non-Nix-user, the code in this PR is undecipherable. In the Nix world, the flake.nix added here is fairly standard, with defaultPackage specifying the default package (for nix shell github:aaronjanse/3mux) and defaultApp specifying the default executable (for nix run github:aaronjanse/3mux).

@aaronjanse aaronjanse requested a review from PotatoParser March 7, 2021 22:09
@aaronjanse
Copy link
Owner Author

Oh, heads up that this can be tested via nix run github:aaronjanse/3mux/mar2021-add-flake, although I assume you don't want to install Nix just to test a PR

@PotatoParser
Copy link
Collaborator

Oh, heads up that this can be tested via nix run github:aaronjanse/3mux/mar2021-add-flake, although I assume you don't want to install Nix just to test a PR

Nah, I'll definitely install Nix :)

README.md Outdated Show resolved Hide resolved
@nikhiljha
Copy link

nikhiljha commented Mar 8, 2021

You can test this PR with docker run -it nixpkgs/nix-unstable nix run "github:aaronjanse/3mux/mar2021-add-flake" --experimental-features "nix-command flakes" if you don't have Nix :)

Copy link
Collaborator

@PotatoParser PotatoParser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as intended

@aaronjanse aaronjanse merged commit 984b2b8 into master Mar 8, 2021
@aaronjanse aaronjanse deleted the mar2021-add-flake branch March 8, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants