-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.net 5 single-file deployment robustness #65
Comments
This comment has been minimized.
This comment has been minimized.
haraldsteinlechner
added a commit
that referenced
this issue
Aug 9, 2021
haraldsteinlechner
added a commit
that referenced
this issue
Aug 9, 2021
Fixed this, plugin loading support was a bit tricky because you have to get the assemblies from the bundle. This library makes this easy fortunately: https://github.com/Droppers/SingleFileExtractor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in introspection/plugin loading we heavily make use of assembly.location et al. This is no longer possible in .net 5 - https://docs.microsoft.com/en-us/dotnet/api/system.reflection.assembly.location?view=net-5.0#remarks
the background description can be found here: https://github.com/dotnet/designs/blob/main/accepted/2020/single-file/design.md
In 5f67063 we took a first step towards this goal and made some bits generally more robust, e.g. got rid of those:
What remains is to find a solution which allows us to scan for potential plugin assemblies.
There are numerous projects with similar problems. Maybe we can get some information there, e.g. nuke-build/nuke#764
The text was updated successfully, but these errors were encountered: