-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD support #72
Conversation
ah, I see you're not using Travis CI anymore and github action doesn't support BSDs yet. |
I am using Travis, for fast feedback. Travis is probably just having issues reporting status at the moment, which it seems to have had several times over the last few months, or it's something else I have to look at again. Could you restore the previous Travis rows? |
Also, the Windows build is failing. It's not due to any of the warnings in the log (those are caused by Ctypes and are not fatal). My first guess is it is due to |
Sorry for Travis, it is fixed now and all green: https://travis-ci.org/github/aantron/luv/builds/707711320 About Cygwin I'm not sure why it's failing. Looking at how dune detects whether to use gmake, it might be an issue, but I'm not sure what a |
27b54bc
to
d132315
Compare
This should be fixed now hopefully. The issue was that – as you said – gmake is not installed by Cygwin and Dune detects whether to use gmake or make by first detecting if gmake exists, if it is then use it, otherwise use make. However in this CI environment Strawberry Perl was installed and in the path, and it is installed with My fix is to use |
All green. Though if you decide not to use this I understand and will not delay the release of 0.5.4 any longer. |
I won't have time to properly review this until probably the next libuv release, but I do want to include it. Would you mind letting the 0.5.4 release proceed? I wasn't explicitly trying to support FreeBSD as of 0.5.4, but I will support it in future releases. |
Sure, I just merged it. Sorry for the bother |
Thanks! |
My local virtualized freebsd is a bit slow so testing here using Travis CI.
The issue on FreeBSD is that the default make command is BSD make, not GNU make (which is required)