Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD support #72

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Add FreeBSD support #72

merged 4 commits into from
Sep 8, 2020

Conversation

kit-ty-kate
Copy link
Contributor

My local virtualized freebsd is a bit slow so testing here using Travis CI.

The issue on FreeBSD is that the default make command is BSD make, not GNU make (which is required)

@kit-ty-kate
Copy link
Contributor Author

ah, I see you're not using Travis CI anymore and github action doesn't support BSDs yet.
I've converted the Travis script to test only FreeBSD if you want to enable it as well. Here is the Travis build that I've enabled on my fork to prove this fixes the issue: https://travis-ci.org/github/kit-ty-kate/luv/builds/707672562 (it's all green)

@aantron
Copy link
Owner

aantron commented Jul 13, 2020

I am using Travis, for fast feedback. Travis is probably just having issues reporting status at the moment, which it seems to have had several times over the last few months, or it's something else I have to look at again. Could you restore the previous Travis rows?

@aantron
Copy link
Owner

aantron commented Jul 13, 2020

Also, the Windows build is failing. It's not due to any of the warnings in the log (those are caused by Ctypes and are not fatal). My first guess is it is due to gmake perhaps not being available in typical Cygwin environments, such as the one used by opam-repository-mingw and the one distributed by esy. I'm not sure if that's properly a Dune issue (of which command it chooses to run), but I couldn't release Luv with a newly-broken Windows build in any case.

@kit-ty-kate
Copy link
Contributor Author

Sorry for Travis, it is fixed now and all green: https://travis-ci.org/github/aantron/luv/builds/707711320

About Cygwin I'm not sure why it's failing. Looking at how dune detects whether to use gmake, it might be an issue, but I'm not sure what a gmake binary would be if it's not GNU make: https://github.com/ocaml/dune/blob/5c1f104088d277e51af18ab79698fc70b068f934/src/stdune/bin.ml#L43

@kit-ty-kate kit-ty-kate force-pushed the freebsd branch 2 times, most recently from 27b54bc to d132315 Compare July 13, 2020 18:55
@kit-ty-kate
Copy link
Contributor Author

This should be fixed now hopefully. The issue was that – as you said – gmake is not installed by Cygwin and Dune detects whether to use gmake or make by first detecting if gmake exists, if it is then use it, otherwise use make. However in this CI environment Strawberry Perl was installed and in the path, and it is installed with gmake, so dune just used it (C:\Strawberry\c\bin\gmake.exe).

My fix is to use %{make} if we're in a Unix environment (Linux or BSD) or make otherwise (Win32 or Cygwin)

@kit-ty-kate
Copy link
Contributor Author

All green. Though if you decide not to use this I understand and will not delay the release of 0.5.4 any longer.

@aantron
Copy link
Owner

aantron commented Jul 21, 2020

I won't have time to properly review this until probably the next libuv release, but I do want to include it. Would you mind letting the 0.5.4 release proceed? I wasn't explicitly trying to support FreeBSD as of 0.5.4, but I will support it in future releases.

@kit-ty-kate
Copy link
Contributor Author

Sure, I just merged it. Sorry for the bother

@aantron aantron merged commit bed7fda into aantron:master Sep 8, 2020
@aantron
Copy link
Owner

aantron commented Sep 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants