Sieve of Eratosthenes #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An algorithm to generate all prime numbers up to a certain number
Tests the Sieve of Eratosthenese implementation
|
Hi @maxm2017, Thanks for contributing. I will shortly review your PR. Cheers, |
aalhour
reviewed
Oct 16, 2017
Algorithms/SieveOfEratosthenes.cs
Outdated
| @@ -0,0 +1,57 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Please move this file into the Algorithms/Numeric package.
| @@ -0,0 +1,34 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Please refer to the other tests in this project on how to use Assertions and modify your tests to start asserting for expected values instead of writing them to the standard output.
55 tasks
MetSystem
pushed a commit
to MetSystem/C-Sharp-Algorithms
that referenced
this pull request
Sep 6, 2018
* Sieve Of Eratosthenes An algorithm to generate all prime numbers up to a certain number * Sieve of Eratosthenes test Tests the Sieve of Eratosthenese implementation * Delete SieveOfEratosthenes.cs * Add files via upload * Delete SieveOfEratosthenesTest.cs * Add files via upload * Added Sieve of Eratosthenes test Added Sieve of Eratosthenes test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Sieve of Eratosthenes implementation and test