New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding language tag as env var and document env vars #1

Closed

pwnyprod wants to merge 1 commit into aPinat:main from pwnyprod:main

pwnyprod commented Aug 1, 2022

No description provided.


          adding language tag as env var and document env vars

5452b61

Owner

aPinat commented Aug 1, 2022

First of all, I never really wanted to add more info/instructions/documentation to this repo for many reasons.

Secondly, the pretty much all the changes you are making are either completely wrong or irrelevant:

Changing hl is useless as it only changes the language the esports API is responding in and absolutely does not have to do with actual location or perhaps the leagues returned. However you then fail to see whether actual geolocation might matter further below in the code.
Your descriptions for key and token are absolutely incorrect and you should have seen that, if you actually tried it out.

aPinat closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet