Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trim the ending slash from consensus RPC #487

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

kvinwang
Copy link
Contributor

@kvinwang kvinwang commented Jan 8, 2025

Without this fix, helios doesn't work when --consensus-rpc is given:

$ cargo run -- ethereum --rpc-port 14433 --network mainnet --execution-rpc https://ethereum-rpc.publicnode.com --consensus-rpc https://ethereum.operationsolarstorm.org
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.40s
     Running `target/debug/helios ethereum --rpc-port 14433 --network mainnet --execution-rpc 'https://ethereum-rpc.publicnode.com' --consensus-rpc 'https://ethereum.operationsolarstorm.org'`
2025-01-08T02:21:17.908637Z  INFO helios::rpc: rpc server started at 127.0.0.1:14433
2025-01-08T02:21:18.591966Z ERROR helios::consensus: sync failed err=could not fetch bootstrap: rpc error on method: bootstrap, message: status: 404, raw response: b""

Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit 5c61864 into a16z:master Jan 8, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants