-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release the linux riscv64gc version #374
Conversation
After v0.18.0, jsonrpsee::core::Error was removed. These are just naive changes to get it to compile. See: https://github.com/paritytech/jsonrpsee/releases/tag/v0.18.0
paritytech/jsonrpsee#1137 This change allows to compile with jsonrpsee v0.19.0
Thanks for the work here! A couple of questions/comments:
|
They could be one pr, yes. I found it important to provide clear traceability and space for others to review what every change of cargo.lock brings. I only reviewed a couple of projects in the chain of dependencies, and I don't have rust experience to assure the security of everything that is being changed. I can andjust to whatever you prefer. I can make a pr for heliosup if these commits look good, or put it in the same single pr. |
We can use this as a working PR as this includes all the work from the other two. Feel free to add the changes to heliosup in this PR as well. |
@ncitron done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Oh could you run |
Thanks for the review. I've pushed the fmt fix. |
Depends on #372.
Part of #370.