Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the linux riscv64gc version #374

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Conversation

come-maiz
Copy link
Contributor

Depends on #372.

Part of #370.

@wiz-a16z
Copy link

wiz-a16z bot commented Sep 12, 2024

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 0 0 0 0 0
Vulnerabilities 0 0 0 0 3 3
Sensitive Data 0 0 0 0 0 0
Secrets 0 0 0 0 0 0
Total 0 0 0 0 3 3

View scan details in Wiz

@ncitron
Copy link
Collaborator

ncitron commented Sep 16, 2024

Thanks for the work here!

A couple of questions/comments:

  1. Why are there separate PRs for upgrading jsonrpc from 17->18 and from 18->19? Could this just be one PR?
  2. I think we may need to look into updating our installer, heliosup, to support installing on risc-v. You can find the code for this in the heliosup folder.

@come-maiz
Copy link
Contributor Author

come-maiz commented Sep 17, 2024

They could be one pr, yes. I found it important to provide clear traceability and space for others to review what every change of cargo.lock brings. I only reviewed a couple of projects in the chain of dependencies, and I don't have rust experience to assure the security of everything that is being changed. I can andjust to whatever you prefer.

I can make a pr for heliosup if these commits look good, or put it in the same single pr.

@ncitron
Copy link
Collaborator

ncitron commented Sep 18, 2024

We can use this as a working PR as this includes all the work from the other two. Feel free to add the changes to heliosup in this PR as well.

This was referenced Sep 18, 2024
@come-maiz
Copy link
Contributor Author

@ncitron done

Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron
Copy link
Collaborator

ncitron commented Sep 19, 2024

Oh could you run cargo fmt so the CI passes? Don't worry about the tests, this is just because it can't access github secrets when in a PR from a fork.

@come-maiz
Copy link
Contributor Author

Thanks for the review. I've pushed the fmt fix.

@ncitron ncitron merged commit b9bc6bf into a16z:master Sep 26, 2024
4 of 5 checks passed
@ncitron ncitron mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants