Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make file_db benchmark runable #364

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix: make file_db benchmark runable #364

merged 2 commits into from
Sep 9, 2024

Conversation

hsyodyssey
Copy link
Contributor

Description

  • Due to the migration from ether-rs to Alloy and changes in some basic API parameter types, the benchmark part was unable to run properly.
  • This PR fixes the tests for file_db.
  • The other benchmark tests involve changes related to the testnet, which would require more extensive modifications. Since the file_db test does not involve network requests, it is submitted as a separate PR

Local test result
image

ncitron
ncitron approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit 7c706a3 into a16z:master Sep 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncitron ncitron ncitron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsyodyssey @ncitron