Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚🍎🤖 Apple pay and Google pay support #12

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

a-tokyo
Copy link
Owner

@a-tokyo a-tokyo commented Nov 16, 2020

Description:

  • add documentation to support Apple pay and Google pay

closes #4

@codecov-io
Copy link

Codecov Report

Merging #12 (c9e7492) into main (eba5714) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files           3        3           
  Lines          55       55           
  Branches       19       19           
=======================================
  Hits           31       31           
  Misses         16       16           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba5714...c9e7492. Read the comment docs.

Copy link

@AnLuoRidge AnLuoRidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

One comment: Since the fix does not work in Expo, it's better to either persuade users to read the original issue thread or mention it in your README to get that idea.

Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided some modifications, feel free to accept it or not :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@a-tokyo a-tokyo merged commit f8d8091 into main Nov 26, 2020
@a-tokyo a-tokyo deleted the 📚🍎🤖-Apple-pay-and-Google-pay-support branch November 26, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apple pay and google pay support?
5 participants