Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/strict temporal validation #16

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

JesusMcCloud
Copy link
Collaborator

  • Update to WARDEN-roboto 1.7.0
    • Android attestation statements (for SW, HW, but not Hybrid Nougat Attestation) do now verify attestation creation time!
    • Refer to the WARDEN-roboto changelog!
  • Change Android verification offset calculation:
    It is now the sum of the toplevel offset and the Android-specific offset
  • Change the reason for iOS attestation statement temporal invalidity:
    • It is now AttestationException.Content.iOS(cause = IosAttestationException(…, reason = IosAttestationException.Reason.STATEMENT_TIME))
      • This reason was newly introduced in this release, making it binary and source incompatible!
    • iOS attestations are now also rejected if their validity starts in the future
    • The validity time can now be configured in the same way as for Android, using the attestationStatementValiditySeconds property
    • Any configured verificationTimeOffset is NOT automatically compensated for any more. This means if you have previously used a five minutes offset, you now have to manually increase the attestationStatementValiditySeconds to 10 * 60!

@JesusMcCloud JesusMcCloud requested a review from nodh October 31, 2024 17:24
@JesusMcCloud
Copy link
Collaborator Author

Once through, I'll prepare e release right away

@JesusMcCloud JesusMcCloud force-pushed the feature/strictTemporalValidation branch from 14e7aa8 to b9cf167 Compare November 5, 2024 11:04
@JesusMcCloud JesusMcCloud merged commit d8a3a58 into development Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants