[fix] change progressbar for pdb download #394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes
When using the download_pdb_multiprocessing function, a progress bar for each individual download would be created. This was quite confusing since the progress bars change to quickly to see anything; at the same time one does not know how far the download process is in practice
WhatsApp.Video.2024-05-03.at.21.14.16.mp4
In this MR, this is changed so that the process instead is monitored by one overall progress bar that gives more informative information about the progress. It does this via the imap_unordered function that returns the requests async; every download request that returns increments the bar so that we have a more realistic idea of how far the download process is.
What testing did you do to verify the changes in this PR?
I downloaded several pdbs, either just a few or a few thousand.
Pull Request Checklist
./CHANGELOG.md
file (if applicable)./graphein/tests/*
directories (if applicable)./notebooks/
(if applicable)python -m py.test tests/
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,python -m py.test tests/protein/test_graphs.py
)black .
andisort .