Use pointers to allow the AST to be modified. Implement visitor support. #1114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Visitor
interface that allows the AST to be traversed and rewrittenThe goal of this PR is to allow the community to create compile-time plugins for Templ. Some examples could include:
We could also generalize a few patterns:
This PR ended up a bit larger than I would have liked. While you could implement the
Visitor
pattern without making the AST pointers, it effectively makes it so the AST is read-only. Being able to modify the AST opens up a lot more possibilities.Let me know if this is a direction you're interested in heading. Tests pass, but there's a few more tests I'd like to contribute before merging.
Also in the #templ channel in the Gophers Slack if you'd like to chat further first.