BugFix: Fix the alignment of audio duration and video duration after concatenate_videoflips #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…concatenate_videoclips
|
Can you provide some code triggering the error, I cannot reproduce it. |
added 2 commits
January 30, 2025 23:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use concatenate_videoclips to concatenate my video clips, I find that the concatenated clip's duration property does not align with its audio's duration property when the last video clip to be concatenated has no audio. This will cause much error when using the concatenated clip after, such as clip.subclip will report an ValueError. So I modify the code in concatenate_videoclips to set the audio's duration align with video's duration.