Fixed double encoded URLs #921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced spaces with + signs and removed encodeURI function usage on url
|
💖 Thanks for opening this pull request! 💖 |
Closed
|
This is fix for #920 |
|
@fri-K - did you test the changes in my dev branch? I don't think this url encode is needed |
|
Hi, |
|
As you already have fix for #920, then I think we can close this pull request? |
|
Before we close it, did you check if my dev branch is working for you? |
|
Yes I did and I responded in bug thread before writing here :) |
|
fixed by pliablepixels@9f04d91 and pliablepixels@4c38f6d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced spaces with + signs and removed encodeURI function usage on url