"Authentication Success" reported, even when not possible

[dstulken]

Platform & OS Version

iOS 12.3.1

The version of zmNinja you are reporting:

1.3.073

The version and OS of ZoneMinder you are using:

Doesn't matter.  (see below).

Device details:

iPhone SE

What is the nature of your issue

Bug

Details

If zmNinja is configured with both ZM authentication and basic authentication disabled, then the app will display a "ZoneMinder authentication success" banner upon startup, regardless of whether any connectivity to the ZoneMinder server was actually established.

For example, in the attached screenshot, the iPhone device was in airplane mode with wifi disabled, yet zmNinja still reports a successful authentication. Clearly no communication, let alone authentication, could have been possible in this case, so the display of the status message is quite misleading - especially when followed moments later by the API Access Error messages. For situations where network connectivity is unreliable, for example, this can lead to a lot of head-scratching in determining where the failure is located, as it gives the impression that at least some level of communication with the ZoneMinder server had been established.

One possible solution to this bug would be to simply not display any authentication banners of any kind if both styles of auth are disabled in the app settings, instead reserving both success and failure prompts for when the user had at least one form of authentication enabled.

zmNinja Debug Logs

Zoneminder Logs (if applicable)

(Not applicable)

Web Server Error Logs (if applicable, especially for streaming errors or API error)

(Not applicable)

Thanks!

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you follow the issue template or I may not respond.