Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate From/To date in Event Filter #330

Closed
PartialVolume opened this issue Sep 15, 2016 · 4 comments
Closed

Validate From/To date in Event Filter #330

PartialVolume opened this issue Sep 15, 2016 · 4 comments

Comments

@PartialVolume
Copy link
Contributor

PartialVolume commented Sep 15, 2016

Platform & OS Version
Kubuntu 16.04 and Android V6

The version of the app you are reporting:
V1.2.23D Linux and Android 1.2.21

Device details:
Linux desktop HTC M8

What is the nature of your issue
Bug

Details
Maybe this bug report is kinda picky, but thought I'd log it. It involves validation of the filter dates. I think a user is much more likely to come across it on the Desktop version than the Android version due to the fact on the Android version you don't get the option to type in the dates but have to select from a calendar.

Ok so I'm on the Desktop version, I'm typing away, it's late and I'm tired and decide to check the events using the date/time filter. I enter the FROM date as 15-09-2106, time as 9:00 and the TO date as 15-09-2016, time as 12:00. ZmNinja reports no events. Strange I thought as I knew there were events.

Did you spot my typo ? Yep I typed the from date 90 years into the future, but instead of ZmNinja informing me I'm an idiot and should learn to type it lead me to believe there are no events ...

With the Android version it also does not check that the FROM date/time is before the TO date/time but because it requires the date to be entered by the use of a calendar it's less likely your going to select a different year or though thinking about it maybe it's not so difficult if you hit the wrong date/day by mistake.

Nick

pliablepixels added a commit that referenced this issue Sep 16, 2016
@PartialVolume
Copy link
Contributor Author

Hi,
If I understand your changes correctly the dates entered should not be any greater today date, however it doesn't solve the problem for a from date greater than the to date that are both set in the past.

Nick

pliablepixels added a commit that referenced this issue Sep 18, 2016
@pliablepixels
Copy link
Member

Yup, added code to swap too if f>t

@PartialVolume
Copy link
Contributor Author

Thanks

@pliablepixels
Copy link
Member

closing, please reopen if it doesn't work (will make a new release in a few days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants