-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuntimeException: stop failed after recording is completed #26
Comments
Also, I'm not sure why the version |
I can see a popular solution here https://stackoverflow.com/questions/16221866/mediarecorder-failed-when-i-stop-the-recording |
Hi @sagrawal31! |
Thank you @3akat for the reply. Wanted to update, not sure why but the same app works fine in an Emulator running Android 8. |
Any update here guys? We are eagerly waiting for a fix/solution/workaround. |
Hi Shashank, My colleague is looking into this. As soon as there is an update he will push it up and update you that it is available. :) |
Hi @sagrawal31, thank you for the detailed description, but I was not able to reproduce the issue on my devices and emulators. Looks like the issue is specific to a Samsung device, I'm trying to understand what's going on. |
Hi @3akat I'm not really sure what's happening in the Samsung device. This device is the latest and only a year old. So this shouldn't be a problem. What is the next step are you taking to figure out the problem? Do you need something from my side? |
@3akat I have been doing the research about this and I got this https://stackoverflow.com/questions/52084401/android-mediarecorder-not-working-in-some-devices To help you out (and ultimately, to help myself 😃), can you let me know a way that I can set |
This is just my guesswork, so please feel free to say no if you are confident that this won't work :) |
I literally have no knowledge of this media/camera thing but I can see that the audio encoder is set to So can you release a snapshot version which gives us the ability to customize the audio encoder and then I can change & try in my Samsung device? |
See it says here the same that |
Another thread which might jog your mind react-native-audio-toolkit/react-native-audio-toolkit#149 |
Yup, that could be the cause. My main goal now is to reproduce the issue before fixing it. I wasn't able to find the J6 device, but I will test the app on some other Samsungs with android 8 and 9. |
Sure, @3akat let me know once you released it. I'll try it out. |
@sagrawal31, I've pushed the |
Hi @3akat, thank you for releasing the version. I added I even tried all other |
So that means the issue is not in the audio encoder, thanks for the help :) |
There are two types of behaviours: When only
|
Not really sure. But my concern is that why the camera freezes as soon as we start the recording. Maybe it's something about the video? |
freezing is actually the most common case when the app crashes during recording. In other words if anything bad happens - the video will freeze or blackout |
Agreed. But this is true for the first case when there is a crash during recording. But in the 2nd case, the recording starts successfully (with camera screen freeze) and 20s timer keeps running on the top but an exception is not thrown unless I press the stop button to pause the recording. |
And according to the documentation:
Which is true in our case because even after the timer runs for 20 seconds, no video was recorded (since the camera was frozen) and when we stop it, it throws the RuntimeException. Is this helps? I don't have much knowledge but just trying to be your help 😃 |
@3akat I managed to create a video for you to demonstrate the actual problem that I'm trying to explain as 2nd scenario. It's there in YouTube https://youtu.be/2jtqFrlUqEM You will see that the timer runs on the top-right corner but the app crashes when the timer ends (or when we manually stop the recording). |
Thanks for sharing this! Will take a look. |
Hi @sagrawal31, I've tried testing the app on three different Samsung devices - no issues. Tomorrow I'll try to get more. |
Hi @3akat I have tried restarting the device in the past and just after seeing this comment, I restarted it after proper shutdown but the same issue 😞 |
Just jumping in Shashank, is your device maybe jailbroken? |
No, Bane. It’s not.
|
I even tried turning off the "Developer Options" from the Settings. |
Thank you, @3akat After you clarified the issue, I Googled about camera2 API integration in Samsung and I saw a lot of posts like https://r2.community.samsung.com/t5/Galaxy-J/Samsung-please-enable-camera-2-API-on-Samsung-galaxy-j6/td-p/1801370 |
Yeah, as I said looks like device doesn't support Camera2 |
Thank you @3akat we are testing this in all devices and will update you with that. |
Hi @sagrawal31, I have tested on J5. Unfortunately I was not able to reproduce the crash, but the preview was not working and the recording was not starting at all, so I hope the cause will be the same. |
Samsung phone box in India has a specific label "Designed for India" so maybe some configuration is different (although, I have heard that it's about SIM slots).
Actually, by a crash, I meant the same. For us, the recording never starts. Although, preview used to work but as soon as we start the recording, it throws this RuntimeException and after a few minutes (of app being frozen), it crashes (Android OS shows a popup this "Xyz app is not responding").
Did you mean that the SDK is now trying to detect the device which does not properly support/implement Camera2 API and if that condition meets, you use Camera2 API? If yes, I'm quite afraid @3akat that if we release this, it might break in any of the devices as we have listed above. Because the release How can we assure that it won't break on these devices? |
That is important details, please describe them exacly next time :) In this case this had no influence but could have in other cases.
That's right.
That's a good question. Do you have access to those device or this were remote users? |
Actually, I explained this earlier in #26 (comment) & #26 (comment) 😄 never directly used the word "crash" in the beginning but the end result of this issue lead to app crash (after a few minutes).
We do not have access to all those devices where it was crashing earlier. Some of them are of real end-users. |
ah, that means I missed something. For some reason I was focused on
Roger that. I'll try to find out how to make sure that it will be working on the devices you've shared. |
Thank you @3akat I'll be waiting to hear from you! |
Hi @sagrawal31, hope you're doing well too! |
Hi @3akat, we are using the version Regarding the logs, I couldn't get anything yet because those are the remote users.
But you released |
Oh I didn't know |
That's fine, I also didn't know it till yesterday.
Yes, @3akat we are trying to prepare a list for you along with the logs. We have Firebase crashlytics installed but for some reason, it is not showing up there. |
Hi @sagrawal31, tomorrow I plan to try to integrate crashlitics to see if there is any issues and since I can't reproduce camera issue manually I will write autotest and execute it in cloud. Hope this will help to find the device where I can debug issues you have. |
That would be really really helpful, @3akat |
Hi @sagrawal31. |
Hi @3akat. Thanks for the new release. Is this release |
Hey, I just checked the debugging page after a very long time and surprised to see that it is logging various errors which might help you figure the issue. Here is a snap: And the biggest thing is that it shows the devices (of real users) on which it is crashing along with my testing Samsung J6 device. Can you please quickly grab access to this and figure out why we are still having issues with the SDK? Please let me know what you need from me so that you can look into my account's debugger data. |
This actually our usual release with some more fixes/improvements, but I have turn Camera2 API off there like in previus time for you. And thanks for sharing the logs, will analyse :) |
Thanks a ton for this. I'll try this. But another concern, since we know that your internal logger can track the issue, do you still want me to try that release? Should we use it and release it on our production app?
I'll be waiting for a more stable fix. |
Any update here @3akat? |
Unfortunately no result for now. Currently we have no access to the service with mobile devices which allow to run autotests, so I did manual testing on about 20 more devices with 5 different builds - no issues. |
Thank you prompt response, again @3akat I appreciate this. I understand that you are not able to reproduce this on different devices but you have access to these logs which looks pretty straightforward to me. For example: Am I making sense? |
Hi @sagrawal31, |
Hi @sagrawal31, |
Hi, @3akat. Thank you for updating me advance! Let me know as soon as you have something. |
Hi @sagrawal31! |
That's really great, @3akat. Thanks for your effort and the update. I'll surely try this very soon. |
Description
I'm using the latest master 1bf79f9 to run the app locally for testing and surprised to see this isn't working.
As soon as the 20s is completed (or even I manually submit the recording), an exception is being thrown:
I even tried upgrading the dependency from
0.82.0
tocom.github.ZiggeoJitpackService:Android-SDK:0.83.0_rc4
but it also has the same issue.Environment
The text was updated successfully, but these errors were encountered: