Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand search bar capabilities #32

Merged
merged 13 commits into from
Jun 12, 2024

Conversation

kaylee-kiako
Copy link
Contributor

Expands the search functionality to additionally support:

  • searching by ingredient (ingredient:<keyword>)
  • searching by cookware (cookware:<keyword>)
  • excluding a search term (!<term>, for example, !cookware:oven for recipes that don't need an oven)
  • searching for ingredients and cookware that contain spaces (<a>+<b>, for example, ingredient:black+beans)
    • While this does allow tags to include spaces, it is not presently used due to being considered invalid.
  • searching partial matches for tags, ingredients, and cookware (for example, tag:din would match the dinner tag)
  • locally group search terms ((<term> <term>), for example, !(ingredient:chicken ingredient:pasta) would exclude recipes that contain both chicken and pasta)
  • searching for either of a series of terms (<term> | <term>, for example, ingredient:chicken | ingredient:steak | ingredient:beef would match any recipes with one of those three ingredients)

@kaylee-kiako kaylee-kiako changed the title Feature/search ingredient Expand search bar capabilities Jun 11, 2024
@Zheoni
Copy link
Owner

Zheoni commented Jun 11, 2024

Fix the small things I commented and I can merge. I like the implementation of the search 😄

@kaylee-kiako
Copy link
Contributor Author

That should address your comments! Let me know if there's anything else that should be dealt with.

@Zheoni
Copy link
Owner

Zheoni commented Jun 12, 2024

Awesome! Thank you!

@Zheoni Zheoni merged commit 585e61a into Zheoni:main Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants