Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Drop keyword argument drop #814

Merged
merged 49 commits into from
Dec 24, 2022
Merged

MAINT: Drop keyword argument drop #814

merged 49 commits into from
Dec 24, 2022

Conversation

Zeroto521
Copy link
Owner

@Zeroto521 Zeroto521 commented Dec 23, 2022

  • closes #xxxx
  • whatsnew entry

Don't add this argument to control drop or not.
It totally could be simplified.

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #814 (59517c9) into main (93aaefa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         145      145           
  Lines        2026     2034    +8     
  Branches      441      450    +9     
=======================================
+ Hits         2020     2028    +8     
  Misses          1        1           
  Partials        5        5           
Impacted Files Coverage Δ
dtoolkit/geoaccessor/dataframe/to_geoframe.py 100.00% <ø> (ø)
...olkit/geoaccessor/geodataframe/select_geom_type.py 100.00% <ø> (ø)
dtoolkit/geoaccessor/geodataframe/to_h3.py 100.00% <ø> (ø)
dtoolkit/geoaccessor/geoseries/geodistance.py 100.00% <ø> (ø)
dtoolkit/geoaccessor/geoseries/reverse_geocode.py 100.00% <ø> (ø)
dtoolkit/geoaccessor/geoseries/select_geom_type.py 100.00% <ø> (ø)
dtoolkit/geoaccessor/geoseries/to_h3.py 100.00% <ø> (ø)
dtoolkit/geoaccessor/geoseries/xy.py 100.00% <ø> (ø)
dtoolkit/geoaccessor/series/to_geoseries.py 100.00% <ø> (ø)
dtoolkit/geoaccessor/dataframe/from_wkb.py 100.00% <100.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Zeroto521 Zeroto521 merged commit 8808722 into main Dec 24, 2022
@Zeroto521 Zeroto521 deleted the drop-argument branch December 24, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant