use set instead of array for actionNames

Zeral-Zhang · Dec 12, 2024 · 04b1e85 · 04b1e85
1 parent 9d770d9
commit 04b1e85
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/app/client/src/ce/entities/DataTree/dataTreeJSAction.test.ts b/app/client/src/ce/entities/DataTree/dataTreeJSAction.test.ts
@@ -191,7 +191,7 @@ describe("generateDataTreeJSAction", () => {
         myVar1: "SMART_SUBSTITUTE",
         myVar2: "SMART_SUBSTITUTE",
       },
-      actionNames: ["myFun2", "myFun1"],
+      actionNames: new Set(["myFun2", "myFun1"]),
     };
     const resultData = generateDataTreeJSAction(jsCollection);
 
@@ -390,7 +390,7 @@ describe("generateDataTreeJSAction", () => {
         myVar1: "SMART_SUBSTITUTE",
         myVar2: "SMART_SUBSTITUTE",
       },
-      actionNames: ["myFun2", "myFun1"],
+      actionNames: new Set(["myFun2", "myFun1"]),
     };
 
     const result = generateDataTreeJSAction(jsCollection);

diff --git a/app/client/src/ce/entities/DataTree/dataTreeJSAction.ts b/app/client/src/ce/entities/DataTree/dataTreeJSAction.ts
@@ -46,7 +46,7 @@ export const generateDataTreeJSAction = (
   const dependencyMap: DependencyMap = {};
 
   dependencyMap["body"] = [];
-  const actions = js.config.actions;
+  const actions = js.config.actions || [];
   // TODO: Fix this the next time the file is edited
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const actionsData: Record<string, any> = {};
@@ -89,7 +89,7 @@ export const generateDataTreeJSAction = (
       dynamicBindingPathList: dynamicBindingPathList,
       variables: listVariables,
       dependencyMap: dependencyMap,
-      actionNames: actions.map((action) => action.name),
+      actionNames: new Set(actions.map((action) => action.name)),
     },
   };
 };
diff --git a/app/client/src/ce/entities/DataTree/types.ts b/app/client/src/ce/entities/DataTree/types.ts
@@ -96,7 +96,7 @@ export interface JSActionEntityConfig extends EntityConfig {
   moduleId?: string;
   moduleInstanceId?: string;
   isPublic?: boolean;
-  actionNames: string[];
+  actionNames: Set<string>;
 }
 
 export interface JSActionEntity {

diff --git a/app/client/src/ce/workers/Evaluation/evaluationUtils.ts b/app/client/src/ce/workers/Evaluation/evaluationUtils.ts
@@ -1114,7 +1114,7 @@ export const isPropertyAnEntityAction = (
 
   const { actionNames } = entityConfig as JSActionEntityConfig;
 
-  return actionNames.includes(propertyPath);
+  return actionNames.has(propertyPath);
 };
 
 export const convertMicroDiffToDeepDiff = (

diff --git a/app/client/src/workers/Evaluation/JSObject/test.ts b/app/client/src/workers/Evaluation/JSObject/test.ts
@@ -213,7 +213,7 @@ describe("saveResolvedFunctionsAndJSUpdates", function () {
         pluginType: "JS",
         name: "JSObject1",
         actionId: "64013546b956c26882acc587",
-        actionNames: ["myFun1", "myFun2"],
+        actionNames: new Set(["myFun1", "myFun2"]),
       } as JSActionEntityConfig,
     };
     const entityName = "JSObject1";

diff --git a/app/client/src/workers/common/DataTreeEvaluator/test.ts b/app/client/src/workers/common/DataTreeEvaluator/test.ts
@@ -768,7 +768,7 @@ describe("isDataField", () => {
       dependencyMap: {
         body: ["myFun2", "myFun1"],
       },
-      actionNames: ["myFun1", "myFun2"],
+      actionNames: new Set(["myFun1", "myFun2"]),
     },
     JSObject2: {
       actionId: "644242aeadc0936a9b0e71cc",
@@ -822,7 +822,7 @@ describe("isDataField", () => {
       dependencyMap: {
         body: ["myFun2", "myFun1"],
       },
-      actionNames: ["myFun1", "myFun2"],
+      actionNames: new Set(["myFun1", "myFun2"]),
     },
     MainContainer: {
       defaultProps: {},