Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Allow more time between thread CPU slices in db_init_outside_future_executor #5310

Merged
merged 1 commit into from
Oct 4, 2022
Merged

fix(test): Allow more time between thread CPU slices in db_init_outside_future_executor #5310

merged 1 commit into from
Oct 4, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 3, 2022 •
edited by arya2
Loading

Motivation

The db_init_outside_future_executor test is failing because its timeout is too short.

Closes #5295.

Review

@arya2 wrote the original test.

This seems like a high priority because it is causing CI failures.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 3, 2022
@teor2345 teor2345 self-assigned this Oct 3, 2022
@teor2345 teor2345 requested a review from a team as a code owner October 3, 2022 01:34
@teor2345 teor2345 requested review from dconnolly and removed request for a team October 3, 2022 01:34
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #5310 (5ccfeac) into main (211dbb4) will increase coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5310      +/-   ##
==========================================
+ Coverage   79.07%   79.20%   +0.13%     
==========================================
  Files         308      308              
  Lines       39560    39560              
==========================================
+ Hits        31281    31334      +53     
+ Misses       8279     8226      -53

@teor2345 teor2345 mentioned this pull request Oct 3, 2022
Merged
5 tasks
arya2
arya2 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mergify bot added a commit that referenced this pull request Oct 4, 2022
@mergify
Merge of #5310
8a54085
@mergify mergify bot mentioned this pull request Oct 4, 2022
Closed
@mergify mergify bot merged commit cea6223 into main Oct 4, 2022
@mergify mergify bot deleted the fix-db-init-test branch October 4, 2022 02:51
@teor2345 teor2345 mentioned this pull request Oct 11, 2022
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@dconnolly dconnolly Awaiting requested review from dconnolly dconnolly is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase the timeout for db_init_outside_future_executor
2 participants
@teor2345 @arya2