Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(dev): Add CHANGELOG checks to PR review template #5202

Merged
merged 2 commits into from
Sep 21, 2022
Merged

change(dev): Add CHANGELOG checks to PR review template #5202

merged 2 commits into from
Sep 21, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

We want to check CHANGELOG entries as part of PR reviews.

Solution

  • Check PR name that is used for release drafter entries
  • Check labels that will be used for release drafter categories
  • Check extra info in CHANGELOG for breaking changes, new features, large changes

Review

This is urgent because we want to check these things in new PRs, so making releases is easier.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need a CHANGELOG intro? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

Follow Up Work

@teor2345 teor2345 added A-docs Area: Documentation A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement P-High 🔥 labels Sep 20, 2022
@teor2345 teor2345 requested a review from a team as a code owner September 20, 2022 00:09
@teor2345 teor2345 self-assigned this Sep 20, 2022
@teor2345 teor2345 requested review from arya2 and removed request for a team September 20, 2022 00:09
@teor2345 teor2345 added C-cleanup Category: This is a cleanup and removed C-enhancement Category: This is an improvement labels Sep 20, 2022
arya2
arya2 approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot mentioned this pull request Sep 21, 2022
Closed
mergify bot added a commit that referenced this pull request Sep 21, 2022
@mergify
Merge of #5202
da9bcbe
@mergify mergify bot mentioned this pull request Sep 21, 2022
Closed
@mergify mergify bot merged commit 694390c into main Sep 21, 2022
@mergify mergify bot deleted the pr-template-changelog branch September 21, 2022 18:47
@teor2345 teor2345 mentioned this pull request Oct 11, 2022
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @arya2