Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to use reddsa crate #152

Merged
merged 1 commit into from
Feb 1, 2023
Merged

refactor to use reddsa crate #152

merged 1 commit into from
Feb 1, 2023

Conversation

conradoplg
Copy link
Contributor

Closes ZcashFoundation/frost#39

  • Use reddsa crate and delete duplicated code
  • Remove FROST code. We could try to keep the public API and use the FROST code in add Pallas and Jubjub ciphersuites and FROST support reddsa#33 but that might be too much work, so I'll wait on a decision on that. Alternatively we could move the non-generic API from the PR to this repo (i.e. just define the ciphersuite in reddsa, and define the non-generic sign, aggregate etc. functions in this repo)

dconnolly
dconnolly approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dconnolly dconnolly self-requested a review February 1, 2023 23:18
@dconnolly dconnolly merged commit 96febcf into main Feb 1, 2023
@dconnolly dconnolly deleted the use-reddsa branch February 1, 2023 23:22
@daira daira mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate/port redjubjub to frost-core / FROST spec v05+
2 participants
@conradoplg @dconnolly