all: use OsRng instead of thread_rng() #861
Open
+283
−349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While our libraries don't do RNG directly and take an CryptoRng from the caller, we do have a bunch of tests and examples that do RNG and that people will inevitably copy.
Reading
rand
s CHANGELOG while reviewing #853, I noticed that it has a new"rand is not a crypto library"
policy. Itsthread_rng
that we were using is also not fork-safe. Looking for alternatives I saw that librustzcash usesOsRng
, which seems to be the right thing to do (even if it's still inrand
, but it's basically agetrandom()
wrapper that implementsCryptoRng
, which is exactly what we need).This changes all usages of
thread_rng()
to useOsRng
instead.